(December 5, 2018 at 11:54 am)KevinM1 Wrote:(December 3, 2018 at 8:09 am)bennyboy Wrote: This is a good example of why MVC is a thing, by the way. Here, you have some really cool programmed stuff, tied in to some really bad internet views. There are now (so far as I can tell) 3 people here right now who could design your website, including all navigation, in less than an hour.
What we couldn't do (or at least not easily) is design something that will spit out the assembly language for a given formula. That is a spectacularly cool thing.
Yeah, separation of concerns is key, not just with web programming, but programming in general.
The compiler page does look a hell of a lot better than the rest of his site. While a Windows 95 inspired look isn't all that fetching in 2018 (it's literally a 23 year old design aesthetic), at least it looks like something I recognize and I have a somewhat intuitive idea of how to engage with it.
But the rest of the site is still Geocities, using old (I mean, late 90s/early 2000s) techniques to render content. No separation of concerns (external CSS or JavaScript), repeated calls to getElementsByTagName and getElementById on the same elements which is incredibly inefficient and should be a code smell to any student, a bouncing ball and a fade-in effect for the entire site for no real reason, random colors with no sense of theme (plus gradients), etc.
Suggestions, for like the 5th time:
No gradients
Pick 2-3 colors that aren't black and white for your overall theme (black and white is for the main body text)
Pick colors that don't clash (look at a freaking color wheel)
No gradients
Pick a maximum of two fonts
Your primary font should be very readable... since your site is mostly technical, sans-serif, with a good looking monospace (I like Adobe's Source Code Pro) for any code examples
No frivolous bullshit - no random cloud background, no fade-in, no bouncing ball
Consolidate and separate your code - external CSS and JavaScript where possible, adhere to DRY (don't repeat yourself) principles, save any element you obtain by one of the getElement(s)By... functions in a variable, etc.
100 percent agree with what he said. Simple is optimal. Once you reformat it, you can expand a bit from there, but you can't to keep things as uniform as possible.
